Convert degenerate torus (A=0, B=C) to sphere #63
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 87.23% 87.20% -0.04%
==========================================
Files 3 3
Lines 752 750 -2
Branches 198 197 -1
==========================================
- Hits 656 654 -2
Misses 52 52
Partials 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an MCNP torus surface has A=0 and B=C, it geometrically degenerates to a sphere of radius B centered at (x0, y0, z0). OpenMC's torus surfaces don't accept A=0 (see openmc-dev/openmc#3813), so these cases (rare) previously produced an invalid surface.
Added test_torus_degenerate_sphere in tests/test_surfaces.py, parametrized over tx/ty/tz, asserting the result is an openmc.Sphere with the expected center and radius. The existing test_torus cases still pass (non-degenerate parameters continue to produce XTorus/YTorus/ZTorus).